Refactor Print.cpp for consistency #5816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uniformed parameters (str, num) across "print" and corresponding "println". Reorder methods to better separate non-ln and ln versions. Signed-off-by: Patrick Roncagliolo <[email protected]>
|
This looks like a sane cleanup to me. This is related to (mostly in the sense that it touches the same code and will probably conflict) to #5829. |
|
Ok, I'll wait for the #5829 to merge and then fix the patch in this PR |
|
#5829 actually removes println from Print.cpp (except for println(void)), so that weird order issue is already handled by that. The random arg names still persist though; it is true that they're a bit confusing. |
|
I had a look to your PR (#5829), and I think it's a great cleanup. When it's merged, maybe I'll check for arg names refactor. I subscribed to your PR so I'll know when to rebase and start from updated sources. |
facchinm
added
the
Print and Stream class
|
|
|
Closing for obsolescence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Roncagliolo [email protected]